Regenerate with widened UDT name limit - #566
Draft
leighmcculloch wants to merge 2 commits into
Draft
Conversation
This was referenced Jul 30, 2026
leighmcculloch
force-pushed
the
const-xdr-serialization
branch
2 times, most recently
from
August 6, 2026 12:44
807385f to
595950c
Compare
leighmcculloch
force-pushed
the
regenerate-with-widened-name-limit
branch
from
August 7, 2026 05:57
de33951 to
99a031a
Compare
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Part of a stack of PRs that must merge in this order.
A first group of PRs deliver const-encoded contract specs, so that contract specs are produced at compile time instead of at proc-macro execution time. This provides the foundation for the capability to construct the specs from information that is not known at proc-macro execution and only known at compile time, like the fully qualified name of a type:
A second group of PRs deliver fully qualified type names in contract specs. Instead of a type having the name
Contextit will have the namesoroban_sdk::auth::Context. Qualified type names make it possible to uniquely identify types in the spec, even when they have the same name. This resolves several problems with contract specs the type identify problem (stellar/rs-soroban-sdk#1570), type aliases limitations (stellar/rs-soroban-sdk#1857), and optimise spec shaking data section size (stellar/rs-soroban-sdk#1978):What
Advance the
xdrsubmodule to the contract spec definition that widens the user-defined type name limit, and regenerate. The name ofScSpecTypeUdtand of the four user-defined type definition entries is nowStringM<128>, and aSC_SPEC_TYPE_NAME_LIMITconst is generated.Why
The Rust SDK is moving to a qualified name for a user-defined type, and cannot encode one under the previous limit of 60.